Project

General

Profile

Actions

Bug #14277

closed

Password policy enforcement bypass

Bug #14277: Password policy enforcement bypass

Added by Nate McGraw about 2 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Category:
-
Start date:
07/24/2024
Due date:
% Done:

100%

Estimated time:
Navigateur:
Firefox
Votre version de Silverpeas:
6.3
Système d'exploitation:
Votre base de données:
Toutes
Livraison en TEST:
Livraison en PROD:

Description

When creating an account or changing password, a request is made to check that the password complies with existing password policies and then a separate request is made to create the account. No check is made to ensure that the password that is tested for compliance to password policy matches the one that is submitted for account creation meaning that by manipulating the second request, you could set a password to '1' or a similarly noncomplex password.

Updated by Miguel Moquillon about 2 years ago Actions #1

  • Assignee set to Miguel Moquillon
  • Target version set to Version 6.4.2

Updated by Miguel Moquillon about 2 years ago Actions #3

  • Status changed from New to In progress...

Updated by Miguel Moquillon about 2 years ago Actions #4

  • Status changed from In progress... to Resolved
  • % Done changed from 0 to 100
The change/set of a password is made within two steps (two requests from the client):
  • The first one is to check the password satisfies all the password rules;
  • The last one is to save effectively the password.

In order to avoid a mismatch between the password that was checked and the one that has to be saved, the password to save is compared to the checked one. For doing, the checked password is cached under an auto generated key. The client asking to effectively save the new password has to pass this key. If this key is invalid or not provided, then an error is sent back. If the checked password doesn't match the password to save, an error is also sent back. By this way, with a double verification, we ensure to block any attempts to circumvent the process of password change/set.

See PR https://github.com/Silverpeas/Silverpeas-Core/pull/1352

Updated by Miguel Moquillon almost 2 years ago Actions #5

  • Status changed from Resolved to Closed

Merged into the branches 6.4.x and master

Actions

Also available in: PDF Atom